Skip to content

opt-dist: add an option for setting path to stage0 root #144164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

opt-dist: add an option for setting path to stage0 root #144164

wants to merge 1 commit into from
+14 −8

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Jul 19, 2025 •
edited
Loading

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 19, 2025
@ognevny ognevny changed the title Opt dist stage0 root opt-dist: add an option for setting path to stage0 root Jul 19, 2025
@ognevny ognevny marked this pull request as ready for review July 19, 2025 06:49
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2025

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@ognevny ognevny force-pushed the opt-dist-stage0-root branch 2 times, most recently from 38f8102 to 0d8e7c1 Compare July 21, 2025 12:38
@ognevny
Copy link
Contributor Author

ognevny commented Jul 21, 2025

@Kobzol rebased

Kobzol
Kobzol reviewed Jul 21, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try.

@bors try

@Kobzol
Copy link
Member

Kobzol commented Jul 21, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

⌛ Trying commit 0d8e7c1 with merge d14f82b…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 21, 2025
@rust-bors
Auto merge of #144164 - ognevny:opt-dist-stage0-root, r=<try>
d14f82b 
 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->
r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

💔 Test failed

@ognevny
Copy link
Contributor Author

ognevny commented Jul 21, 2025

oh I see

@ognevny
opt-dist: add an option for setting path to stage0 root
fa92464 
in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
@ognevny ognevny force-pushed the opt-dist-stage0-root branch from 0d8e7c1 to fa92464 Compare July 21, 2025 12:58
@Kobzol
Copy link
Member

Kobzol commented Jul 21, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

⌛ Trying commit fa92464 with merge b5b89d4…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 21, 2025
@rust-bors
Auto merge of #144164 - ognevny:opt-dist-stage0-root, r=<try>
b5b89d4 
 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->
r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

☀️ Try build successful (CI)
Build commit: b5b89d4 (b5b89d44539e233a14d265614e2cbe813ba7443c, parent: 67819923ac8ea353aaa775303f4c3aacbf41d010)

@Kobzol
Copy link
Member

Kobzol commented Jul 21, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit fa92464 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#144164 - ognevny:opt-dist-stage0-root, r=Ko…
dc0b46d 
…bzol

 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144286 - matthiaskrgr:rollup-1h1nn6b, r=matthiaskrgr
0d50eab 
Rollup of 8 pull requests

Successful merges:

 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#144164 - ognevny:opt-dist-stage0-root, r=Ko…
5c9a37f 
…bzol

 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ognevny @rustbot @Kobzol @bors