-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Add more test case to check if the false note related to sealed trait suppressed #144240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add more test case to check if the false note related to sealed trait suppressed #144240
Conversation
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additions. It would be nice if the name of the commit contained the name of the modified testcase, e.g. Add a case for ui test false-sealed-traits-note.rs
, as this commit would appear in the master branch, which would be obvious at a glance.
14e968d
to
ec2084a
Compare
This comment has been minimized.
This comment has been minimized.
Please fix the failure at https://triage.rust-lang.org/gha-logs/rust-lang/rust/46405993368#2025-07-21T17:27:23.9058573Z |
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
ec2084a
to
0aa6170
Compare
@rustbot ready |
Thanks! @bors r+ rollup |
…ported-in-another-issue, r=fee1-dead Add more test case to check if the false note related to sealed trait suppressed Closes rust-lang#143121 I started to fix the issue but I found that this one has already been addressed in this PR (rust-lang#143431). I added an additional test to prove the reported thing has been resolved just in case. I think we can discard this pull request if there's no need to add such kind of tests👍🏻
…ported-in-another-issue, r=fee1-dead Add more test case to check if the false note related to sealed trait suppressed Closes rust-lang#143121 I started to fix the issue but I found that this one has already been addressed in this PR (rust-lang#143431). I added an additional test to prove the reported thing has been resolved just in case. I think we can discard this pull request if there's no need to add such kind of tests👍🏻
…ported-in-another-issue, r=fee1-dead Add more test case to check if the false note related to sealed trait suppressed Closes rust-lang#143121 I started to fix the issue but I found that this one has already been addressed in this PR (rust-lang#143431). I added an additional test to prove the reported thing has been resolved just in case. I think we can discard this pull request if there's no need to add such kind of tests👍🏻
…ported-in-another-issue, r=fee1-dead Add more test case to check if the false note related to sealed trait suppressed Closes rust-lang#143121 I started to fix the issue but I found that this one has already been addressed in this PR (rust-lang#143431). I added an additional test to prove the reported thing has been resolved just in case. I think we can discard this pull request if there's no need to add such kind of tests👍🏻
Closes #143121
I started to fix the issue but I found that this one has already been addressed in this PR (#143431). I added an additional test to prove the reported thing has been resolved just in case.
I think we can discard this pull request if there's no need to add such kind of tests👍🏻