Remove the witness type from coroutine *args* (without actually removing the type) #144458
+273
−335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
force-pushed
the
no-witness-mini
branch
from
2bf9c66 to
7209b8e
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
no-witness-mini
branch
from
7209b8e to
8756bdc
Compare
lcnr
reviewed
Jul 28, 2025
| if self.reveal_coroutine_witnesses { | ||
| queue_type(self, args.as_coroutine().witness()); | ||
| ty::Coroutine(def_id, args) => { | ||
| if self.exhaustive { |
There was a problem hiding this comment.
please add the FIXME to exhaustive again
|
r=me after nit |
lcnr
added
S-waiting-on-author
compiler-errors
force-pushed
the
no-witness-mini
branch
from
8756bdc to
e976578
Compare
|
@bors r=lcnr rollup=never |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 31, 2025
Remove the witness type from coroutine *args* (without actually removing the type) This does as much of #144157 as we can without having to break #143545 and/or introduce some better way of handling higher ranked assumptions. Namely, it: * Stalls coroutines based off of the *coroutine* type rather than the witness type. * Reworks the dtorck constraint hack to not rely on the witness type. * Removes the witness type from the args of the coroutine, eagerly creating the type for nested obligations when needed (auto/clone impls). I'll experiment with actually removing the witness type in a follow-up. r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does as much of #144157 as we can without having to break #143545 and/or introduce some better way of handling higher ranked assumptions.
Namely, it:
I'll experiment with actually removing the witness type in a follow-up.
r? lcnr