-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Stabilize sse4a
and tbm
target features
#144542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- remove some stabilized target features from `gate.rs`
rustbot has assigned @petrochenkov. Use |
cc @Amanieu, @folkertdev, @sayantn |
Thanks. This needs a PR to the Reference. cc @tgross35 @RalfJung @Amanieu @workingjubilee @rust-lang/lang-docs |
The usual question for target feature stabilizations: |
@rfcbot fcp merge |
Team member @tmandry has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
@rfcbot reviewed |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
No, these just enable a few instructions. They don't expose any additional register or have any impact on ABI. |
@rfcbot reviewed |
This PR stabilizes the feature flag
sse4a_target_feature
andtbm_target_feature
(tracking issue #44839).Public API
The 2
x86
target featuressse4a
andtbm
Also, these were added in LLVM2.6 and LLVM3.4-rc1, respectively, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too!
As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. The intrinsics were stabilized long ago, in 1.27.0
cc @rust-lang/lang
@rustbot label I-lang-nominated
r? lang