Skip to content

Enable T-compiler backport nomination #144583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Enable T-compiler backport nomination #144583

merged 1 commit into from
Jul 30, 2025

Conversation

apiraino
Copy link
Contributor

This patches the triagebot.toml so that it will trigger a backport label on pull requests fixing regressions. Applying a backport label will trigger creating a Zulip thread. For now the configuration only for T-compiler labeled regressions.

Comments in the code explain how it works. Documentation on the forge.

[backport.foo]

# The pull request MUST have one of these labels
required_pr_labels = ["T-compiler"]

# The regression MUST have this label
required_issue_label = "regression-from-stable-to-beta"

# if the above conditions matches, the PR will receive these labels
add_labels = ["beta-nominated"]

Anything to think about before merging this?

thanks for a review

@apiraino apiraino requested review from Urgau and Kobzol July 28, 2025 13:25
@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

Anything to think about before merging this?

Do we know how noisy this might be? I assume not very, considering it's limited to regressions labelled with T-compiler only 🤔

@apiraino apiraino force-pushed the enable-t-compiler-backport-nomination branch from 206d8fd to f94f2c4 Compare July 28, 2025 13:40
@rustbot

This comment has been minimized.

Sign in to view
@apiraino
Copy link
Contributor Author

apiraino commented Jul 28, 2025 •
edited
Loading

Do we know how noisy this might be? I assume not very, considering it's limited to regressions labelled with T-compiler only 🤔

Correct. If it works as intended ( 😅 ), we will have backport triggers only on T-compiler beta+stable regressions labeled P-high or P-critical

@apiraino
Copy link
Contributor Author

Error: Invalid triagebot.toml at position 56:2:

TOML parse error at line 56, column 2
   |
56 | [backport.t-compiler-beta-backport]
   |  ^^^^^^^^
unknown field `required_pr_labels`, expected one of `required-pr-labels`, `required-issue-label`, `add-labels`

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@Urgau in your review comment you asked me to use kebab-case. Only now I notice that it's nowhere used in this .toml file. Did I misunderstand your suggestion? i'm confused 🤔

@Urgau
Copy link
Member

Urgau commented Jul 28, 2025

@Urgau in your review comment you asked me to use kebab-case. Only now I notice that it's nowhere used in this .toml file. Did I misunderstand your suggestion? i'm confused 🤔

It's used, it's used. There is just a overwhelming amount of [assign] and [autolabel] that uses the old snake_case.

@Urgau
Copy link
Member

Urgau commented Jul 28, 2025 •
edited
Loading

@rustbot author
r? Urgau

@rustbot rustbot assigned Urgau and unassigned Mark-Simulacrum Jul 28, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@apiraino apiraino force-pushed the enable-t-compiler-backport-nomination branch from f94f2c4 to 21ff9cf Compare July 28, 2025 16:38
@rustbot

This comment has been minimized.

Sign in to view
@apiraino
Copy link
Contributor Author

It's used, it's used. There is just a overwhelming amount of [assign] and [autolabel] that uses the old snake_case.

do you think it should be fixed or just shrug?

@apiraino apiraino force-pushed the enable-t-compiler-backport-nomination branch from 21ff9cf to c5b4606 Compare July 28, 2025 16:53
@Urgau
Copy link
Member

Urgau commented Jul 28, 2025

do you think it should be fixed or just shrug?

shrug on my part, but if you want to do the work of adding #[serde(alias = "...")] to every snake_case fields, updating every occurrences in the organization, updating the forge and removing the all the #[serde(alias = "...")] feel free

@Urgau Urgau added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2025
jieyouxu
jieyouxu approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, maybe let's give this a shot? If needed, this is easy to revert so that should be fine.

Feel free to also r=me unless there's something else.

@Urgau
Copy link
Member

Urgau commented Jul 29, 2025

Let's try it and see how it goes.

@bors r=jieyouxu,Urgau always

@bors
Copy link
Collaborator

bors commented Jul 29, 2025

📌 Commit c5b4606 has been approved by jieyouxu,Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2025
@jhpratt jhpratt mentioned this pull request Jul 29, 2025
Merged
bors added a commit that referenced this pull request Jul 29, 2025
@bors
Auto merge of #144658 - jhpratt:rollup-jdzhz27, r=jhpratt
c8bb4e8 
Rollup of 8 pull requests

Successful merges:

 - #144034 (tests: Test line number in debuginfo for diverging function calls)
 - #144510 (Fix Ord, Eq and Hash implementation of panic::Location)
 - #144583 (Enable T-compiler backport nomination)
 - #144586 (Update wasi-sdk to 27.0 in CI)
 - #144605 (Resolve: cachify `ExternPreludeEntry.binding` through a `Cell`)
 - #144632 (Update some tests for LLVM 21)
 - #144639 (Update rustc-perf submodule)
 - #144640 (Add support for the m68k architecture in 'object_architecture')

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5334780 into rust-lang:master Jul 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 30, 2025
rust-timer added a commit that referenced this pull request Jul 30, 2025
@rust-timer
Unrolled build for #144583
0ae86bb 
Rollup merge of #144583 - apiraino:enable-t-compiler-backport-nomination, r=jieyouxu,Urgau

Enable T-compiler backport nomination

This patches the triagebot.toml so that it will trigger a backport label on pull requests fixing regressions. Applying a backport label will trigger creating a Zulip thread. For now the configuration only for `T-compiler` labeled regressions.

Comments in the code explain how it works. Documentation [on the forge](https://forge.rust-lang.org/triagebot/backport.html).

```
[backport.foo]

# The pull request MUST have one of these labels
required_pr_labels = ["T-compiler"]

# The regression MUST have this label
required_issue_label = "regression-from-stable-to-beta"

# if the above conditions matches, the PR will receive these labels
add_labels = ["beta-nominated"]
```

Anything to think about before merging this?

thanks for a review
@apiraino apiraino deleted the enable-t-compiler-backport-nomination branch July 30, 2025 10:49
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 31, 2025
@bors
Auto merge of rust-lang#144658 - jhpratt:rollup-jdzhz27, r=jhpratt
af745a4 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#144034 (tests: Test line number in debuginfo for diverging function calls)
 - rust-lang#144510 (Fix Ord, Eq and Hash implementation of panic::Location)
 - rust-lang#144583 (Enable T-compiler backport nomination)
 - rust-lang#144586 (Update wasi-sdk to 27.0 in CI)
 - rust-lang#144605 (Resolve: cachify `ExternPreludeEntry.binding` through a `Cell`)
 - rust-lang#144632 (Update some tests for LLVM 21)
 - rust-lang#144639 (Update rustc-perf submodule)
 - rust-lang#144640 (Add support for the m68k architecture in 'object_architecture')

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

@Kobzol Kobzol Awaiting requested review from Kobzol

Assignees

@Urgau Urgau

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@apiraino @rustbot @rust-log-analyzer @jieyouxu @Urgau @bors @Mark-Simulacrum