Skip to content

Fix typo in DropGuard doc #144634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Fix typo in DropGuard doc #144634

merged 1 commit into from
Jul 29, 2025

Conversation

lucaswerkmeister
Copy link
Contributor

@lucaswerkmeister lucaswerkmeister commented Jul 29, 2025

Follows-up #144236 (I happened to see the typo yesterday but didn’t think it should delay the PR’s merge so I kept quiet, sorryyyyy).

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 29, 2025
@lucaswerkmeister
Copy link
Contributor Author

r? yoshuawuyts

would make sense, I think? (Hopefully this comment doesn’t mess up the rustbot syntax.)

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

Failed to set assignee to yoshuawuyts: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@lqd
Copy link
Member

lqd commented Jul 29, 2025

Thanks! r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 29, 2025

📌 Commit de02a32 has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned scottmcm Jul 29, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2025
bors added a commit that referenced this pull request Jul 29, 2025
Rollup of 6 pull requests

Successful merges:

 - #144560 (coverage: Treat `#[automatically_derived]` as `#[coverage(off)]`)
 - #144566 (Simplify `align_of_val::<[T]>(…)` → `align_of::<T>()`)
 - #144587 (expand: Micro-optimize prelude injection)
 - #144589 (Account for `.yield` in illegal postfix operator message)
 - #144615 (Make resolve_fn_signature responsible for its own rib.)
 - #144634 (Fix typo in `DropGuard` doc)

r? `@ghost`
`@rustbot` modify labels: rollup
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, even though Rustbot wouldn't let me take this one, I'm still coming out of the woodwork regardless to say that this looks good to me. Thank you @lucaswerkmeister!

@bors bors merged commit 7088bf5 into rust-lang:master Jul 29, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jul 29, 2025
Rollup merge of #144634 - lucaswerkmeister:patch-1, r=lqd

Fix typo in `DropGuard` doc

Follows-up #144236 (I happened to see the typo yesterday but didn’t think it should delay the PR’s merge so I kept quiet, sorryyyyy).
@rustbot rustbot added this to the 1.90.0 milestone Jul 29, 2025
@lucaswerkmeister lucaswerkmeister deleted the patch-1 branch July 29, 2025 17:39
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 30, 2025
Fix typo in `DropGuard` doc

Follows-up rust-lang#144236 (I happened to see the typo yesterday but didn’t think it should delay the PR’s merge so I kept quiet, sorryyyyy).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants