Skip to content

Remove SHOULD_EMIT_LINTS in favor of should_emit #144866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove SHOULD_EMIT_LINTS in favor of should_emit #144866

wants to merge 1 commit into from
+11 −4

Conversation

JonathanBrouwer
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 3, 2025
JonathanBrouwer
JonathanBrouwer commented Aug 3, 2025
View reviewed changes
@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 4, 2025

📌 Commit f92934f has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 4, 2025
@Zalathar
Rollup merge of rust-lang#144866 - JonathanBrouwer:should_emit_fix, r…
718d3cf 
…=jdonszelmann

Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`

r? `@jdonszelmann`
@Zalathar Zalathar mentioned this pull request Aug 4, 2025
Closed
bors added a commit that referenced this pull request Aug 4, 2025
@bors
Auto merge of #144891 - Zalathar:rollup-7tsclc3, r=Zalathar
d4eb454 
Rollup of 5 pull requests

Successful merges:

 - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions)
 - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file)
 - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`)
 - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`)
 - #144887 (`rust-analyzer` subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 4, 2025
@samueltardieu
Rollup merge of rust-lang#144866 - JonathanBrouwer:should_emit_fix, r…
ed8fbeb 
…=jdonszelmann

Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`

r? `@jdonszelmann`
@samueltardieu samueltardieu mentioned this pull request Aug 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonathanBrouwer @rustbot @jdonszelmann @bors