Skip to content

Delete tests/ui/threads-sendsync/tcp-stress.rs #144894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Delete tests/ui/threads-sendsync/tcp-stress.rs #144894

wants to merge 1 commit into from
+0 −64

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Aug 4, 2025 •
edited
Loading

This stress test was originally introduced in 65cca4b to detect a UAF in libuv (see #12823), but we no longer use libuv, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures.

Closes #144878 (by removing the test).

r? libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
@jieyouxu jieyouxu added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
@jieyouxu jieyouxu mentioned this pull request Aug 4, 2025
Open
@jieyouxu
Copy link
Member Author

jieyouxu commented Aug 4, 2025

The possibility removing the test altogether is being discussed in #144878 (comment) (for a second libs opinion)

@jieyouxu
Copy link
Member Author

jieyouxu commented Aug 4, 2025

Okay, looks like the consensus from the discussion is yeeting. I'll change this PR to instead yeet the test a bit later.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
@jieyouxu
Remove tcp-stress.rs test
51f60d1 
This stress test was originally introduced in
65cca4b to detect a UAF in libuv (see
RUST-12823), but we no longer use libuv, so remove this test as it was
causing flaky timeout failures. See RUST-144878 for discussion.
@jieyouxu jieyouxu changed the title Downsize tcp-stress.rs again Delete tests/ui/threads-sendsync/tcp-stress.rs Aug 4, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Aug 4, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2025
@ChrisDenton
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 4, 2025

📌 Commit 51f60d1 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: tests/ui/threads-sendsync/tcp-stress.rs
5 participants
@jieyouxu @ChrisDenton @bors @ibraheemdev @rustbot