Enforce in bootstrap that doc must have stage at least 1 #145011
+469
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
|
☔ The latest upstream changes (presumably #145020) made this pull request unmergeable. Please resolve the merge conflicts. |
As they were previously.
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
|
Rebased over the two merged PRs, should be ready now. @rustbot ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following with the bootstrap cleanups, this time around
docsteps. Should be pretty straightforward, because the supporting infrastructure was already there.The only thing I found a bit fishy is using
Mode::ToolBootstrapas a "catch-all" mode for non-rustc-private steps intool_doc!, but I don't think that we need to distinguish the tools in some special way when documenting them, apart from supportingrustc_private.Before,
x docmore or less defaulted to what we call stage 2 now. Now it is properly stage 1, so e.g.x doc compilerdocuments the compiler using the stage0/beta rust(do)c.r? @jieyouxu