Rollup of 6 pull requests

[tgross35]

Successful merges:

• tests/ui/issues/: The Issues Strike Back [3/N] #144400 (tests/ui/issues/: The Issues Strike Back [3/N])
• Make no_mangle on foreign items explicit instead of implicit #144678 (Make no_mangle on foreign items explicit instead of implicit)
• doc(library): Fix Markdown in Iterator::by_ref #145045 (doc(library): Fix Markdown in Iterator::by_ref)
• Fix doc comment of File::try_lock and File::try_lock_shared #145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
• move type_check out of compute_regions #145047 (move type_check out of compute_regions)
• Add a lot of NLL known-bug tests #145053 (Add a lot of NLL known-bug tests)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[tgross35]

One iffy with a few always

@bors r+ rollup=never p=5

[bors]

📌 Commit 330a4e3 has been approved by tgross35

It is now in the queue for this repository.

[bors]

⌛ Testing commit 330a4e3 with merge 017a6f7...

[rust-log-analyzer]

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

To only update this specific test, also pass `--test-args linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=wasm32-wasip1" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/wasm32-wasip1/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error: attribute should be applied to a foreign function or static
##[error]  --> /checkout/tests/ui/linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn.rs:1:1
   |
---

error[E0455]: link kind `raw-dylib` is only supported on Windows targets
##[error]  --> /checkout/tests/ui/linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn.rs:13:34
   |
LL | #[link(name = "exporter", kind = "raw-dylib")]
   |                                  ^^^^^^^^^^^

error[E0391]: cycle detected when computing codegen attributes of `imported_function`
##[error]  --> /checkout/tests/ui/linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn.rs:16:5
   |
LL |     fn imported_function();
   |     ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: ...which requires getting wasm import module map...
   = note: ...which requires looking up the native libraries of a linked crate...
   = note: ...which again requires computing codegen attributes of `imported_function`, completing the cycle
note: cycle used when checking that `` is well-formed
  --> /checkout/tests/ui/linkage-attr/raw-dylib/windows/link-ordinal-not-foreign-fn.rs:14:1
   |
LL | / extern "C" {
LL | |     #[link_ordinal(13)]
LL | |     fn imported_function();

[bors]

💔 Test failed - checks-actions