resolve: Do not finalize shadowed bindings

[petrochenkov]

I.e. do not mark them as used, or non-speculative loaded, or similar.
Previously they were sometimes finalized during early resolution, causing issues like #144793 (comment).

[rustbot]

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rust-log-analyzer]

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[compiler-errors]

Looks like this triggers a new unused warning in the stdlib? Is this intentional? We probably should crater this if so.

@bors2 try
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rust-bors]

⌛ Trying commit 5feb92e with merge 8c500c7…

To cancel the try build, run the command @bors try cancel.

[petrochenkov]

Looks like this triggers a new unused warning in the stdlib? Is this intentional?

Yes, some new unused items can be detected now.
It shouldn't be common though.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 8c500c7 (8c500c7cefd54fd11d57295f3771d576be9ee415, parent: 2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a)

[petrochenkov]

We probably should crater this if so.

@craterbot check

[craterbot]

👌 Experiment pr-145113 created and queued.
🤖 Automatically detected try build 8c500c7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-145113 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more