Replace unsafe security_attributes function with safe inherit_handle alternative
#145150
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `security_attributes` function is marked as safe despite taking a raw pointer which will later be used. Fortunately this function is only used internally and only in one place that has been basically the same for a decade now. However, we only ever set one bool so it's easy enough to replace with something that's actually safe.
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
Kivooeo
reviewed
Aug 9, 2025
| @@ -80,7 +80,7 @@ pub struct OpenOptions { | |||
| attributes: u32, | |||
| share_mode: u32, | |||
| security_qos_flags: u32, | |||
| security_attributes: *mut c::SECURITY_ATTRIBUTES, | |||
| inherit_handle: bool, | |||
There was a problem hiding this comment.
I spent some time wandering through other reviews and... interesting observation: people really don't like bool flags around here - readability issues, they say, I've been switching to enums myself, even for simple true/false cases
There was a problem hiding this comment.
I think this is much more relevant for function parameters, but this is mostly a struct field and so it's less relevant (I'd even argue marginally harmful).
There was a problem hiding this comment.
I'd just note that OpenOptions uses bool for most parameters. If this were a public API then we'd likely want to be consistent with those existing methods anyway.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 10, 2025
Rollup of 7 pull requests Successful merges: - #144553 (Rehome 32 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145064 (Add regression test for `saturating_sub` bounds check issue) - #145121 (bootstrap: `x.py dist rustc-src` should keep LLVM's siphash) - #145150 (Replace unsafe `security_attributes` function with safe `inherit_handle` alternative) - #145152 (Use `eq_ignore_ascii_case` to avoid heap alloc in `detect_confuse_type`) - #145200 (mbe: Fix typo in attribute tracing) - #145222 (Fix typo with paren rustc_llvm/build.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 10, 2025
Rollup merge of #145150 - ChrisDenton:inherit, r=Mark-Simulacrum Replace unsafe `security_attributes` function with safe `inherit_handle` alternative The `security_attributes` function is marked as safe despite taking a raw pointer which will later be used. Fortunately this function is only used internally and only in one place that has been basically the same for a decade now. However, we only ever set one bool so it's easy enough to replace with something that's actually safe. In the future we might want to expose the ability for users to set security attributes. But that should be properly designed (and safe!).
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Aug 13, 2025
…crum Replace unsafe `security_attributes` function with safe `inherit_handle` alternative The `security_attributes` function is marked as safe despite taking a raw pointer which will later be used. Fortunately this function is only used internally and only in one place that has been basically the same for a decade now. However, we only ever set one bool so it's easy enough to replace with something that's actually safe. In the future we might want to expose the ability for users to set security attributes. But that should be properly designed (and safe!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
security_attributesfunction is marked as safe despite taking a raw pointer which will later be used. Fortunately this function is only used internally and only in one place that has been basically the same for a decade now. However, we only ever set one bool so it's easy enough to replace with something that's actually safe.In the future we might want to expose the ability for users to set security attributes. But that should be properly designed (and safe!).