-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix Crash when indexing into a generic slice with computed length in const fns #145213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eval-exec
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
eval-exec:fix-145138
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
tests/ui/const-generics/generic_const_exprs/ice-qualifs-unevaluated-operand.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
//@ check-pass | ||
//@ revisions: full | ||
// This is a regression test for an ICE in const qualifs where | ||
// `Const::Ty` containing `ty::ConstKind::Unevaluated` was not handled. | ||
// The pattern arises with `generic_const_exprs` and const fn using | ||
// array lengths like `LEN * LEN` and repeat expressions. | ||
|
||
#![cfg_attr(full, feature(generic_const_exprs))] | ||
#![cfg_attr(full, allow(incomplete_features))] | ||
|
||
trait One: Sized + Copy { | ||
const ONE: Self; | ||
} | ||
|
||
const fn noop<T: One>(a: &mut T, b: &mut T) { | ||
let _ = (a, b); | ||
} | ||
|
||
struct Test<T: One, const LEN: usize>([T; LEN * LEN]) | ||
where | ||
[u8; LEN * LEN]:; | ||
|
||
impl<T: One, const LEN: usize> Test<T, LEN> | ||
where | ||
[u8; LEN * LEN]:, | ||
{ | ||
const fn test() -> Self { | ||
let mut a = Self([T::ONE; LEN * LEN]); | ||
let mut i = 0; | ||
while i < LEN { | ||
let mut one = T::ONE; | ||
noop(&mut one, &mut a.0[i * i + 1]); | ||
i += 1; | ||
} | ||
a | ||
} | ||
} | ||
|
||
fn main() {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fact that we've got an unevaluated const ty as a constant value in the body is wrong 🤔 we should not support this but instead fix [MIR building for] GCE to not emit such a thing.
Generally, we're currently working towards a replacement of
generic_const_exprs
which won't have these issues, so we're currently not very actively trying to fix bugs of that feature