Skip to content

Hide docs for core::unicode #145336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clarfonthey
Copy link
Contributor

This module is perma-unstable and shouldn't show up in the public docs. If people want to see the docs for it, they can still run RUSTDOCFLAGS=--document-hidden-items ./x doc library/core.

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 13, 2025
@bjorn3
Copy link
Member

bjorn3 commented Aug 13, 2025

The UNICODE_VERSION constant is marked as stable. Is is actually usable on stable or should the #[stable] be removed?

@joboet
Copy link
Member

joboet commented Aug 13, 2025

The UNICODE_VERSION constant is marked as stable. Is is actually usable on stable or should the #[stable] be removed?

It's not usable as core::unicode::UNICODE_VERSION because the module is unstable, and both the associated and the freestanding stable UNICODE_VERSION constants are redefinitions, not reexports, so I think that yes, the attribute should be removed.

@clarfonthey
Copy link
Contributor Author

According to rustdoc, it's actually marked as unstable, so, the stable attribute here is probably an artefact of the past. I can also confirm this on the current stable.

It's not necessary, but I'll add it to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants