Remove default config from bootstrap #145352

Shourya742 · 2025-08-13T12:52:31Z

This PR removes the default config initialization from parse_inner, as it introduced many assumptions during config setup. Instead, each variable is now manually initialized to eliminate certain invariants in parse_inner and streamline the process.

The PR is still a WIP and has been opened for an initial review.

r? @Kobzol

Kobzol

Heh, I had feedback for you, but I see that Clippy did it for me in one of the commits xD Let me know once it's ready and I'll check the changes locally, but in general looks great.

src/bootstrap/src/core/config/config.rs

bors · 2025-08-15T03:56:49Z

☔ The latest upstream changes (presumably #145407) made this pull request unmergeable. Please resolve the merge conflicts.

Kobzol

Let me know if it's ready for another round of review :)

Kobzol · 2025-08-18T08:21:10Z

src/bootstrap/src/core/download.rs

+impl<'a> DownloadContext<'a> {
+    #[allow(clippy::too_many_arguments)]
+    pub fn new(
+        path_modification_cache: Arc<Mutex<HashMap<Vec<&'static str>, PathFreshness>>>,


I would personally get rid of the new function. It has so many arguments and it's quite hard to see quickly what should be passed to them. Constructing the download context using the struct init syntax is more explicit.

rustbot assigned Kobzol Aug 13, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 13, 2025