Skip to content

Change rustc to say array instead of vector in error messages #16889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2014

Conversation

ftxqxd
Copy link
Contributor

@ftxqxd ftxqxd commented Aug 30, 2014

No description provided.

@huonw
Copy link
Member

huonw commented Aug 31, 2014

I imagine some tests will need to be updated?

@ftxqxd
Copy link
Contributor Author

ftxqxd commented Aug 31, 2014

That’s what I thought, but since it only shows up at the end of errors in brackets (as in expected int, found [int, ..3] (expected int, found vector)) it seems that no tests actually use it. IIRC, I ran make check and the tests passed. Edit: I ran make check again and the tests all passed.

@alexcrichton
Copy link
Member

Could you add this terminology to a test for the future? Just in case this wording gets accidentally changed.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 17, 2014
@bors bors merged commit 5bc27d5 into rust-lang:master Sep 17, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
internal: Enforce utf8 paths

Cargo already requires this, and I highly doubt r-a works with non-utf8 paths generally either. This just makes dealing with paths a lot easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants