Fix the inverted RUST_LOG filter #17331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this as well? |
|
@alexcrichton What, like a run-make test? |
|
You also have the choice of a |
|
How would a |
|
You can call |
|
Ah hah, I can instruct it to examine stdout, and then I should just be able to use the error-pattern directive. |
|
Heh I didn't even realize |
RUST_LOG supports regex filtering of log messages with a syntax like `RUST_LOG=main/foo` to use the regex filter 'foo'. Unfortunately, the filter was inverted, so `RUST_LOG=main/foo` would actually show all messages except the ones containing 'foo'.
lilyball
force-pushed
the
rust_log_pattern_inverted
branch
from
13b02c5 to
e7b2570
Compare
|
@alexcrichton Updated with a test. |
bors
added a commit
that referenced
this pull request
Sep 17, 2014
…xcrichton RUST_LOG supports regex filtering of log messages with a syntax like `RUST_LOG=main/foo` to use the regex filter 'foo'. Unfortunately, the filter was inverted, so `RUST_LOG=main/foo` would actually show all messages except the ones containing 'foo'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST_LOG supports regex filtering of log messages with a syntax like
RUST_LOG=main/footo use the regex filter 'foo'. Unfortunately, thefilter was inverted, so
RUST_LOG=main/foowould actually show allmessages except the ones containing 'foo'.