RFC: Btree query API #27135
Closed
RFC: Btree query API #27135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@gankro Wow, this is really cool, but definitely highlights the need for some kind of parametric mutability. |
| self.map.max().map(|r| r.0) | ||
| } | ||
|
|
||
| /// Gets the closest value to the given key that is less than it. |
There was a problem hiding this comment.
s/key/value/
(Same for the following methods.)
There was a problem hiding this comment.
All should presumably be element.
|
I'm just really happy I didn't have to write 12 node search procedures as well. I was dreading the impl until I realized Found/GoDown was basically sufficient. |
| }}; | ||
| }}, | ||
| Internal(internal_handle) => {{ | ||
| temp_node = internal_handle.into_{dir}_edge{muta_ext}().into_edge{muta_ext}(); |
There was a problem hiding this comment.
There was a tidy error on this line.
|
Bench results: |
| @@ -228,6 +228,665 @@ impl<K: Ord, V> BTreeMap<K, V> { | |||
| } | |||
| } | |||
|
|
|||
| // Rust's macro system is so attrocious at being generic over mutability | |||
There was a problem hiding this comment.
This correction made my day
|
RFC closed. |
|
@apasel422 Note that you might want to steal these bench changes for profiling parent pointer stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the core functionality of rust-lang/rfcs#1195 which is not yet accepted (largely due to bikeshedding naming -- but also on what removal/entry APIs to expose).
Note that the vast majority of the code was generated by a program (see comments).
I believe I've exhaustively tested every single code path with my unit test.
Note that removal/entry APIs are not yet provided; I'm of the opinion that a major refactor of the internals to use parent pointers should be done first. Then search/removal/entry/range can basically share the exact same source code with no overhead. It's also expected to be substantially more efficient due to not needing to maintain an explicit search stack for insert/remove/range/entry.