-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Add is_documentation for IPv6 #32207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you elaborate on the rationale for this addition as well? We aren't currently very principled about the query methods we have so I'm largely just curious. |
RFC 3849 defines this range to be used for documentation only [1]. No end hosts should be assigned addresses in this range. Thus this address can not be a globally routable address. This is how python behaves for this range
Please let me know if I should clarify something else. |
☔ The latest upstream changes (presumably #32211) made this pull request unmergeable. Please resolve the merge conflicts. |
This function returns true if the given IPv6 is reserved for documentation. Also, reject this block in the is_global check
Seems reasonable to me! Tagging with T-libs just to make sure this comes up during triage. |
Add is_documentation for IPv6 This function returns true if the given IPv6 is reserved for documentation. Also, reject this block in the is_global check
This function returns true if the given IPv6 is reserved for
documentation. Also, reject this block in the is_global check