ci: Don't set compiler-builtins-no-f16-f128
#743
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rust-lang/rust be35d37d8b6c ("Use the compiler to determine
whether or not to enable f16 and f128"), `compiler-builtins` relies on
`rustc` to report whether or not `f16` and `f128` are supported, which
is reported by the backend. This means that there should no longer be
any need to set this config in CI.
Backend config: https://github.com/rust-lang/rustc_codegen_gcc/blob/f682d09eefc6700b9e5851ef193847959acf4fac/src/lib.rs#L499-L510
|
@FractalFir: Is this the error you got on Dec Alpha or something: https://github.com/rust-lang/rustc_codegen_gcc/actions/runs/16532424105/job/46760590729?pr=743#step:11:64 ? |
|
Yeah, that's the same error. Looks like GCC is reporting it supports f128 on m68k when it actually doesn't? |
|
Actually, I think the toolchain here is from before rust-lang/rust#143405 merged, meaning rust-lang/rust@be35d37 isn't available. Should have known since that is what we were looking at in #t-compiler/help > How to correctly disable `f16` and `f128` when bootstraping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust be35d37d8b6c ("Use the compiler to determine whether or not to enable f16 and f128"),
compiler-builtinsrelies onrustcto report whether or notf16andf128are supported, which is reported by the backend. This means that there should no longer be any need to set this config in CI.Backend config:
rustc_codegen_gcc/src/lib.rs
Lines 499 to 510 in f682d09