Skip to content

Fix Deser for Other Attributes #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Benjscho
Copy link

Deser failed for other attributes because they were missing the untagged marker.

Fixes #52

Deser failed for other attributes because they were missing the
`untagged` marker.
@Benjscho
Copy link
Author

Actually on testing looks like this is representing the other attribute types as Other too:

                Other(
                    "#[non_exhaustive]",
                ),

need to fix that.

@Benjscho
Copy link
Author

I had a crack at a manual deserializer, but I absolutely might missing something about the crate and the implementation.

In general I'm looking for a way to access which features are needed for an item. Let me know if there's a way I could help with implementing that! I'm guessing there might be some work to reimplement or copy how rustdoc handles cfg_attrs? I'm unclear on how docs.rs is able to show which features are needed for an item.

@TheFunctionalGuy
Copy link

Hello,

I don't want to sound harsh but looking at the README.md it looks like the MR should be in rust-lang/rust:

This repo is a reexport of rustdoc-json-types from the rust repo. Any change to the contents of src/, should be sent to rust-lang/rust, via their normal contribution procedures. Once reviewed and merged there, the change will be pulled to this repo and published to crates.io.

So please consider re-opening the MR there.

Note: I'm not the maintainer of this repo, so I might be wrong.

Cheers,
Julian

@Benjscho
Copy link
Author

No you're right, I think my issue was the nightly version hadn't pulled in the latest types yet!

@Benjscho Benjscho closed this Jul 21, 2025
@Benjscho Benjscho deleted the fix-untagged branch July 21, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialization fails for #[inline]
2 participants