Skip to content

Fill in a few more alumni from git history #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 9, 2024

No description provided.

Comment on lines 8 to +11
"alercah",
"Havvy",
"marioidival",
"matthewjasper",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This archived team was made in #1134 to have somewhere to move alercah out of the old alumni.toml. These are the rest of the members (without the one who does not already have a profile in the people directory).

@@ -11,6 +11,7 @@ alumni = [
"rylev",
"celaus",
"peschkaj",
"sophiajt",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -28,6 +28,7 @@ alumni = [
"aidanhs",
"sophiajt",
"badboy",
"wycats",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -16,7 +16,9 @@ members = [
"sunfishcode",
"yaahc",
]
alumni = []
alumni = [
"shepmaster",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shepmaster was in library-reviewers from #456 to #588. Library-reviewers got deleted instead of archived, but at least the role that shepmaster played overlaps very closely with the modern libs-contributors team. Shepmaster has over 100 assigned library reviews spanning 3 years and standard library PRs spanning even longer. In my opinion the contribution definitely makes sense to recognize as alumni on https://www.rust-lang.org/governance/teams/library#libs-contributors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @m-ou-se

This seems reasonable to me. If anyone is a stickler for absolute historical accuracy we can always bring back the library reviewers team as an archived team later on.

@@ -16,7 +16,9 @@ members = [
"sunfishcode",
"yaahc",
]
alumni = []
alumni = [
"shepmaster",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @m-ou-se

This seems reasonable to me. If anyone is a stickler for absolute historical accuracy we can always bring back the library reviewers team as an archived team later on.

@@ -17,6 +18,7 @@ alumni = [
"pietroalbini",
"pnkfelix",
"rylev",
"sophiajt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the history it seems like this removal was an accident (removed instead of archived).

@rylev rylev merged commit 3161442 into rust-lang:master Jan 9, 2024
@dtolnay dtolnay deleted the lastalumni branch January 9, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants