-
Notifications
You must be signed in to change notification settings - Fork 315
Fill in a few more alumni from git history #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "alercah", | ||
| "Havvy", | ||
| "marioidival", | ||
| "matthewjasper", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This archived team was made in #1134 to have somewhere to move alercah out of the old alumni.toml. These are the rest of the members (without the one who does not already have a profile in the people directory).
| @@ -11,6 +11,7 @@ alumni = [ | |||
| "rylev", | |||
| "celaus", | |||
| "peschkaj", | |||
| "sophiajt", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -28,6 +28,7 @@ alumni = [ | |||
| "aidanhs", | |||
| "sophiajt", | |||
| "badboy", | |||
| "wycats", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -16,7 +16,9 @@ members = [ | |||
| "sunfishcode", | |||
| "yaahc", | |||
| ] | |||
| alumni = [] | |||
| alumni = [ | |||
| "shepmaster", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shepmaster was in library-reviewers from #456 to #588. Library-reviewers got deleted instead of archived, but at least the role that shepmaster played overlaps very closely with the modern libs-contributors team. Shepmaster has over 100 assigned library reviews spanning 3 years and standard library PRs spanning even longer. In my opinion the contribution definitely makes sense to recognize as alumni on https://www.rust-lang.org/governance/teams/library#libs-contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @m-ou-se
This seems reasonable to me. If anyone is a stickler for absolute historical accuracy we can always bring back the library reviewers team as an archived team later on.
| @@ -16,7 +16,9 @@ members = [ | |||
| "sunfishcode", | |||
| "yaahc", | |||
| ] | |||
| alumni = [] | |||
| alumni = [ | |||
| "shepmaster", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @m-ou-se
This seems reasonable to me. If anyone is a stickler for absolute historical accuracy we can always bring back the library reviewers team as an archived team later on.
| @@ -17,6 +18,7 @@ alumni = [ | |||
| "pietroalbini", | |||
| "pnkfelix", | |||
| "rylev", | |||
| "sophiajt", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the history it seems like this removal was an accident (removed instead of archived).
No description provided.