Add long time marker to several slow tests #40558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 047101c; changes) is ready! 🎉 |
user202729
force-pushed
the
long-time-marker-1
branch
from
d637c97 to
0674575
Compare
orlitzky
reviewed
Aug 9, 2025
|
The pre-existing |
actually thinking about it maybe the reason is the first call is slow, and if the first call is marked I keep the original mark just in case (that my guess is incorrect?). If the hypothesis is false then whoever manage to speed up this (if possible at all?) can just remove all of these marks. |
|
Ok, sure, it's harmless in any case. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-40558: Add long time marker to several slow tests This gets rid of about half of the warnings, until someone figure out whether they're intended to be slow, or how they can be sped up. Reference: sagemath#39569, sagemath#39746 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40558 Reported by: user202729 Reviewer(s): Michael Orlitzky, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40558: Add long time marker to several slow tests This gets rid of about half of the warnings, until someone figure out whether they're intended to be slow, or how they can be sped up. Reference: sagemath#39569, sagemath#39746 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40558 Reported by: user202729 Reviewer(s): Michael Orlitzky, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 14, 2025
sagemathgh-40558: Add long time marker to several slow tests This gets rid of about half of the warnings, until someone figure out whether they're intended to be slow, or how they can be sped up. Reference: sagemath#39569, sagemath#39746 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40558 Reported by: user202729 Reviewer(s): Michael Orlitzky, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of about half of the warnings, until someone figure out whether they're intended to be slow, or how they can be sped up.
Reference: #39569, #39746
📝 Checklist
⌛ Dependencies