Skip to content

fixes in spkg-configure.m4's #40568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Aug 11, 2025

This allows external flint 3.3.*, and fixes errors in spkg-configure.4 of roman_numerals_py

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase dimpase requested a review from kiwifb August 11, 2025 05:21
@dimpase dimpase requested a review from vbraun August 11, 2025 05:21
Copy link

Documentation preview for this PR (built with commit 9bbf612; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kiwifb
Copy link
Member

kiwifb commented Aug 11, 2025

Gosh, that was really me that made that "numerical" mistake. LGTM.

Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun
Copy link
Member

vbraun commented Aug 12, 2025

doc-html fails

[sagemath_doc_html-none] [spkg-install] [valuation]       File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/site-packages/sphinx/registry.py", line 544, in load_extension      
[sagemath_doc_html-none] [spkg-install] [valuation]         raise ExtensionError(                                                                                                                          
[sagemath_doc_html-none] [spkg-install] [valuation]     sphinx.errors.ExtensionError: Could not import extension sphinx.builders.latex (exception: No module named 'roman_numerals')                       

@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2025

@vbraun - can you provide top-level config.log for this run?

@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2025

unless roman_numerals is misdetected as available, it must be something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants