Convert partitions into skew partitions automatically #40580
+55
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Aug 13, 2025
There was a problem hiding this comment.
This is a partial fix that will cause confusion because
sage: SP = SkewPartitions()
sage: SP([3,2,1])
will not work. Rather than changing the constructor, better to change the __contains__ and _element_constructor_ of ``SkewPartitions`. Although this will mean doing a bit more work on the subclasses. However, I think it is a better way to do things and be a complete fix.
|
Documentation preview for this PR (built with commit 694e219; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This here should work:
The present patch makes it so.