Do not generate TypeDef for enum #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornilova203
force-pushed
the
do-not-generate-typedef-for-enum
branch
from
a268188 to
673b22e
Compare
jonas
approved these changes
Aug 8, 2018
tests/samples/Typedef.scala
Outdated
| type toggle_e = enum_toggle_e | ||
| type int2int = native.CFunctionPtr1[native.CInt, native.CInt] | ||
| type day2string = native.CFunctionPtr1[enum_days, native.CString] | ||
| type toggle = native.CFunctionPtr1[toggle_e, Unit] | ||
| type enum_days = native.CUnsignedInt | ||
| type enum_toggle_e = native.CUnsignedInt |
There was a problem hiding this comment.
I suggest enums are before function pointers, typedefs and records.
kornilova203
force-pushed
the
do-not-generate-typedef-for-enum
branch
from
673b22e to
e2777eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated typedefs are confusing.
The PR removes generated typedefs for enums.
If a field/parameter/variable has enum type, it references an
Enuminstance directly.Also generated typedefs make #61 difficult to implement because enums and typedefs should be matched (in order to output enumerators right below enum type). It can be done by going through all typedefs, but it does not look good.