This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Enable cross compilation #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @heathermiller |
| @@ -91,24 +96,9 @@ object Compat { | |||
| c.Expr[FastTypeTag[T]](bundle.impl[T]) | |||
| } | |||
|
|
|||
| def FastTypeTagMacros_apply(c: Context)(key: c.Expr[String]): c.Expr[FastTypeTag[_]] = { | |||
| def FastTypeTagMacros_apply(c: Context)(key: c.Expr[String]): c.Expr[FastTypeTag[t]] forSome { type t } = { | |||
There was a problem hiding this comment.
Does not compile on 2.11 otherwise:
[error] .../pickling/core/src/main/scala/pickling/FastTags.scala:58: macro implementation has incompatible shape:
[error] required: (c: scala.reflect.macros.whitebox.Context)(key: c.Expr[String]): c.Expr[scala.pickling.FastTypeTag[_$7]] forSome { type _$7 }
[error] or : (c: scala.reflect.macros.whitebox.Context)(key: c.Tree): c.Tree[]
[error] found : (c: reflect.macros.Context)(key: c.Expr[String]): c.Expr[scala.pickling.FastTypeTag[_]]
[error] type mismatch for return type: c.Expr[scala.pickling.FastTypeTag[_]] does not conform to c.Expr[scala.pickling.FastTypeTag[_$7]] forSome { type _$7 }
[error] def apply(key: String): FastTypeTag[_] = macro Compat.FastTypeTagMacros_apply
[error] ^
[error] one error found
- uses correct existential in FastTypeTag macro - adds source compatibility stubs
|
Addressed review comments. |
|
LGTM! Thanks! |
heathermiller
added a commit
that referenced
this pull request
Apr 10, 2014
Enable cross compilation
phaller
pushed a commit
to phaller/pickling
that referenced
this pull request
Jul 27, 2015
Enable cross compilation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the project to build on both Scala 2.10 and 2.11 without changes.