This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Remove obsolete pomPostProcess from build #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <groupId>org.scalamacros</groupId> | ||
| <artifactId>quasiquotes</artifactId> | ||
| <version>2.0.0-M8</version> | ||
| </dependency> |
There was a problem hiding this comment.
Most likely not going to work, because artifactId includes version. Why not remove this pom hack altogether?
There was a problem hiding this comment.
Oh, ok. Would be great to get rid of this hack- suggestions/PRs welcome! :-)
There was a problem hiding this comment.
What I was suggesting is to remove pomPostProcess altogether. It was necessary when we were depending on paradise-the-fork in order to postprocess away the org.scala-lang.paradise organization. Now we can just remove it and be fine.
phaller
changed the title
|
In @xeno-by we trust, LGTM |
heathermiller
added a commit
that referenced
this pull request
Apr 16, 2014
Remove obsolete pomPostProcess from build
heathermiller
added a commit
that referenced
this pull request
Feb 5, 2015
Remove obsolete pomPostProcess from build
phaller
pushed a commit
to phaller/pickling
that referenced
this pull request
Jul 27, 2015
Remove obsolete pomPostProcess from build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119.
Review by @xeno-by @heathermiller