Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Remove obsolete pomPostProcess from build #120

Merged
merged 1 commit into from
Apr 16, 2014

Conversation

phaller
Copy link
Contributor

@phaller phaller commented Apr 11, 2014

Fixes #119.
Review by @xeno-by @heathermiller

<groupId>org.scalamacros</groupId>
<artifactId>quasiquotes</artifactId>
<version>2.0.0-M8</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely not going to work, because artifactId includes version. Why not remove this pom hack altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok. Would be great to get rid of this hack- suggestions/PRs welcome! :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I was suggesting is to remove pomPostProcess altogether. It was necessary when we were depending on paradise-the-fork in order to postprocess away the org.scala-lang.paradise organization. Now we can just remove it and be fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yey!

@phaller phaller changed the title Add quasiquotes dependency to POM Remove obsolete pomPostProcess from build Apr 16, 2014
@heathermiller
Copy link
Member

In @xeno-by we trust, LGTM

heathermiller added a commit that referenced this pull request Apr 16, 2014
Remove obsolete pomPostProcess from build
@heathermiller heathermiller merged commit 57d84a6 into scala:2.10.x Apr 16, 2014
heathermiller added a commit that referenced this pull request Feb 5, 2015
Remove obsolete pomPostProcess from build
phaller pushed a commit to phaller/pickling that referenced this pull request Jul 27, 2015
Remove obsolete pomPostProcess from build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants