Skip to content

Unintended SafeValue Error #23424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions compiler/src/dotty/tools/dotc/transform/init/Objects.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ class Objects(using Context @constructorOnly):

case v @ SafeValue(_) =>
if v.typeSymbol != defn.NullClass then
// selection on Null is sensible on AST level; no warning for it
// selection on Null is sensible on AST level but not in practice
report.warning("[Internal error] Unexpected selection on safe value " + v.show + ", field = " + field.show + ". " + Trace.show, Trace.position)
end if
Bottom
Expand Down Expand Up @@ -1573,7 +1573,13 @@ class Objects(using Context @constructorOnly):
val target = expr.tpe.widenSingleton.classSymbol.asClass
withTrace(trace2) { resolveThis(target, qual.asInstanceOf[ThisValue], klass) }
case _ =>
withTrace(trace2) { select(qual, expr.symbol, receiver = qualifier.tpe) }
qual match {
// Check if expression is a selection of a method
case v: SafeValue if expr.symbol.is(Flags.Method) =>
withTrace(trace2) { call(v, expr.symbol, args = Nil, receiver = qualifier.tpe, superType = NoType) }
case _ =>
withTrace(trace2) { select(qual, expr.symbol, receiver = qualifier.tpe) }
}

case _: This =>
evalType(expr.tpe, thisV, klass)
Expand Down
7 changes: 7 additions & 0 deletions tests/init-global/pos-tasty/test-safe-value.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package scala.collection.immutable

object A { // These are a safe values, so no warning should be emitted
Node.HashCodeLength
Node.BitPartitionSize
Node.MaxDepth
}