Fix regressions in asSeenFrom introduced in 3.7 #23438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add #22676 to a test? I tested your PR and it fixes the regression. Thanks! |
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in scala#21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in scala#23423.
To make the testcases added in scala#21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
Fixes scala#23423.
Fixes scala#22676.
WojciechMazur
added
the
backport:nominated
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 27, 2025
This was referenced Jun 27, 2025
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 29, 2025
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Jul 3, 2025
jchyb
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 7, 2025
This was referenced Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body of isLegalPrefix used to read:
but was changed to drop the second condition in #21954 (originally included in 3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a number of regressions, the last ones discussed in #23423.
To make the testcases added in #21594 pass, this PR proposes a less drastic change: relax isLegalPrefix as before, unless we're doing an implicit search. This should dramatically reduce the possibility for regressions.
Fixes #23423.
Fixes #22676.