-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix #9260 - Enums copy variance of parent #9709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bishabosha
merged 6 commits into
scala:master
from
dotty-staging:topic/enum-unification
Sep 18, 2020
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a8d07c6
fix #9260: copy variance in derived type parameters
bishabosha 3e0246e
add in explicit type parameters for variant enums
bishabosha 747b2c7
add variance test cases
bishabosha a126ebf
check position of typeparam and document example
bishabosha b1c490a
declare derived type params as synthetic
bishabosha d4769b9
more complete example
bishabosha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
-- Error: tests/neg-custom-args/fatal-warnings/enum-variance.scala:2:12 ------------------------------------------------ | ||
2 | case Refl(f: T => T) // error: covariant T in contravariant position... enum case may require explicit type parameters | ||
| ^^^^^^^^^ | ||
| covariant type T occurs in contravariant position in type T => T of value f | ||
| enum case class Refl may require explicit type parameters to resolve this issue | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
enum View[+T]: | ||
case Refl(f: T => T) // error: covariant T in contravariant position... enum case may require explicit type parameters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package asts | ||
|
||
enum Ast[-T >: Null]: | ||
case DefDef() | ||
|
||
trait AstImpl[T >: Null]: | ||
type Ast = asts.Ast[T] | ||
type DefDef = Ast.DefDef[T] | ||
end AstImpl | ||
|
||
object untpd extends AstImpl[Null]: | ||
|
||
def DefDef(ast: Ast): DefDef = ast match | ||
case ast: DefDef => ast | ||
|
||
end untpd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
class Animal | ||
class Dog extends Animal | ||
|
||
enum Opt[+T]: | ||
case Sm(t: T) | ||
case None | ||
|
||
val smDog: Opt.Sm[Dog] = new Opt.Sm(Dog()) | ||
val smAnimal: Opt.Sm[Animal] = smDog | ||
|
||
enum Show[-T]: | ||
case Refl(op: T => String) | ||
|
||
def show(t: T): String = this match | ||
case Refl(op) => op(t) | ||
|
||
val reflAnimal: Show.Refl[Animal] = new Show.Refl(_.toString) | ||
val reflDog: Show.Refl[Dog] = reflAnimal |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.