Skip to content

3.29.0 release seems to be broken on Python 3.9 and earlier due to importlib_metadata backport #472

@agriyakhetarpal

Description

@agriyakhetarpal

CMake seems to use the importlib_metadata backport dependency for Python 3.8 and 3.9, but maybe it's not declaring that?

I noticed the failure in the CI logs, and then triggered a re-run just in case this was a one-off failure:

  1. https://github.com/pybamm-team/PyBaMM/actions/runs/8436810245/job/23105126965
  2. https://github.com/pybamm-team/PyBaMM/actions/runs/8436810245/job/23106957328

Edit: okay so it is declaring that, just in the optional dependencies table:

[project.optional-dependencies]
test = [
"coverage>=4.2",
"importlib_metadata>=2.0; python_version<'3.10'",
"pytest>=3.0.3",
"pytest-cov>=2.4.0",

and I suppose it should be a required dependency too. It's being used here:

if sys.version_info < (3, 10):
from importlib_metadata import distribution
else:
from importlib.metadata import distribution

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions