-
Notifications
You must be signed in to change notification settings - Fork 36
Closed
Description
CMake seems to use the importlib_metadata
backport dependency for Python 3.8 and 3.9, but maybe it's not declaring that?
I noticed the failure in the CI logs, and then triggered a re-run just in case this was a one-off failure:
- https://github.com/pybamm-team/PyBaMM/actions/runs/8436810245/job/23105126965
- https://github.com/pybamm-team/PyBaMM/actions/runs/8436810245/job/23106957328
Edit: okay so it is declaring that, just in the optional dependencies table:
cmake-python-distributions/pyproject.toml
Lines 36 to 42 in 85a457b
[project.optional-dependencies] | |
test = [ | |
"coverage>=4.2", | |
"importlib_metadata>=2.0; python_version<'3.10'", | |
"pytest>=3.0.3", | |
"pytest-cov>=2.4.0", |
and I suppose it should be a required dependency too. It's being used here:
cmake-python-distributions/src/cmake/__init__.py
Lines 5 to 9 in 85a457b
if sys.version_info < (3, 10): | |
from importlib_metadata import distribution | |
else: | |
from importlib.metadata import distribution | |
awni, Jajauma and enrico-lattuadabraindevices
Metadata
Metadata
Assignees
Labels
No labels