Skip to content

4.x: Fix metadata node events for null tablet map #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

4.x: Fix metadata node events for null tablet map #507

merged 1 commit into from
Apr 7, 2025

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Apr 7, 2025 •
edited
Loading

After #505 tablet map could be empty, we need to address these cases.

@dkropachev dkropachev force-pushed the dk/4.x-fix-tablets-2 branch from de889b1 to e64020c Compare April 7, 2025 11:57
@dkropachev dkropachev requested a review from Bouncheck April 7, 2025 11:57
Bouncheck
Bouncheck reviewed Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not going to be an Optional<TabletMap> after #505?
Shouldnt there be a .get()?

@dkropachev
Copy link
Collaborator Author

Is this not going to be an Optional<TabletMap> after #505? Shouldnt there be a .get()?

it is stored as TabletMap and converted to Optional only at getTabletMap

@dkropachev
Fix metadata events for case when tablet map is empty
f21dff0 
Tablet map could be empty, we need to address these cases.
@dkropachev dkropachev force-pushed the dk/4.x-fix-tablets-2 branch from e64020c to f21dff0 Compare April 7, 2025 12:28
@Bouncheck Bouncheck self-requested a review April 7, 2025 12:41
@dkropachev dkropachev merged commit c3d8010 into scylladb:scylla-4.x Apr 7, 2025
7 of 10 checks passed
@dkropachev dkropachev self-assigned this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bouncheck Bouncheck Bouncheck approved these changes

Assignees

@dkropachev dkropachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkropachev @Bouncheck