(minor improvement): small refactoring in make_token_replica_map() #513
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@mykaul , let me know when you done, it looks good as is. |
I'm not, I'd like to understand the code better. I think it can be further slightly improved. |
While trying to look at some random (flaky?) test (scylladb#510 (comment) ) I saw some (minor) improvements that can be made to make_token_replica_map(): 1. Remove some redundant len() calls to outside the loop(s) 2. Align some variable names, start with num_ ... for them. 3. Move token_offset and host assignment within the loop to closer to where it's used. 4. Only add DCs and hosts that are in the map All those are probably very very minor improvements, perhaps in a large cluster it'll be noticable. Signed-off-by: Yaniv Kaul <[email protected]>
mykaul
force-pushed
the
make_token_replica_map
branch
from
cd57c4d to
64c0e38
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the make_token_replica_map() method in cassandra/metadata.py to improve performance and code clarity through several optimizations:
- Pre-filter hosts to only process those in datacenters with replication factors
- Move length calculations outside loops to avoid redundant computations
- Improve variable naming consistency with
num_prefixes - Reorganize code structure for better locality of use
|
@scylladb/python-driver-maint - please re-review. I hope I did not mess things up - CoPilot is being silly here, I suspect. I'm not sure why the whole CI is broken, doesn't seem to be caused by my changes. |
| dc_racks[host.datacenter].add(host.rack) | ||
| hosts_per_dc[host.datacenter].add(host) | ||
| host_dc = host.datacenter | ||
| if host_dc in dc_rf_map: |
There was a problem hiding this comment.
Even better optimization would be to have a set of hosts run this logic over it, instead of running it for all tokens.
There was a problem hiding this comment.
Maybe, but out of scope for this small PR
While trying to look at some random (flaky?) test (#510 (comment) ) I saw some (minor) improvements that can be made to make_token_replica_map():
All those are probably very very minor improvements, perhaps in a large cluster it'll be noticable.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.