Skip to content

Commit 6e6df4f

Browse files
remove after dependency (#79)
* remove after dependency * fix typo * fix var name * clean up return statement * simplify function
1 parent 9392b72 commit 6e6df4f

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

lib/protos.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66

77
var Emitter = require('component-emitter');
8-
var after = require('@ndhoule/after');
98
var each = require('@ndhoule/each');
109
var events = require('analytics-events');
1110
var every = require('@ndhoule/every');
@@ -334,8 +333,15 @@ exports._wrapInitialize = function() {
334333
*/
335334

336335
exports._wrapPage = function() {
337-
// Noop the first page call if integration assumes pageview
338-
if (this._assumesPageview) return this.page = after(2, this.page);
336+
var page = this.page;
337+
var initialPageSkipped = false;
338+
this.page = function() {
339+
if (this._assumesPageview && !initialPageSkipped) {
340+
initialPageSkipped = true;
341+
return;
342+
}
343+
return page.apply(this, arguments);
344+
};
339345
};
340346

341347
/**

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
},
2222
"homepage": "https://github.com/segmentio/analytics.js-integration#readme",
2323
"dependencies": {
24-
"@ndhoule/after": "^1.0.0",
2524
"@ndhoule/clone": "^1.0.0",
2625
"@ndhoule/defaults": "^2.0.1",
2726
"@ndhoule/each": "^2.0.1",

yarn.lock

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
# yarn lockfile v1
33

44

5-
"@ndhoule/after@^1.0.0":
6-
version "1.0.0"
7-
resolved "https://registry.yarnpkg.com/@ndhoule/after/-/after-1.0.0.tgz#e6d86d121448247ac742ff3a61c63fae83ee1191"
8-
dependencies:
9-
"@ndhoule/arity" "^2.0.0"
10-
11-
"@ndhoule/arity@^2.0.0":
12-
version "2.0.0"
13-
resolved "https://registry.yarnpkg.com/@ndhoule/arity/-/arity-2.0.0.tgz#26bfa0b9755ced9aea819d4e6e7a93db27a5b658"
14-
155
"@ndhoule/clone@^1.0.0":
166
version "1.0.0"
177
resolved "https://registry.yarnpkg.com/@ndhoule/clone/-/clone-1.0.0.tgz#0f68394a95008cf360370e101924564a70927afc"

0 commit comments

Comments
 (0)