Adds Search/InitiateCheckout events #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 17, 2018 08:58
gpsamson
force-pushed
the
gps/fbp-events
branch
from
4556fcd to
cb7ecf8
Compare
jlee9595
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
SearchandInitiateCheckoutevents for parity with FB Pixel + SS.NOTE: The version jumps from 2.5.2 to 2.5.4 because master is behind a version (2.5.3 is published and used in a.js private)
Are there breaking changes in this PR?
No
Has this been tested end-to-end? Please provide screenshots on how the fix now populates in the end tool. If not, what was done to test?
Yeup.
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration (if applicable)?
SS is in the works and this adds parity to that.
Does this require a metadata change? If so, please link the PR from https://github.com/segmentio/destination-scripts.
What are the relevant tickets?
Link to CC ticket
https://segment.atlassian.net/browse/CC-1650
List all the tests accounts you have used to make sure this change works
Personal Pixel account
Helpful Docs