Skip to content

Remove auto formatting pre-commit hook #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Conversation

ccnixon
Copy link
Contributor

@ccnixon ccnixon commented Sep 20, 2018

What does this PR do?
Removes the prettier auto-formatting from the pre-commit hook and just runs it as a linter

Are there breaking changes in this PR?

Has this been tested end-to-end? Please provide screenshots on how the fix now populates in the end tool. If not, what was done to test?

Any background context you want to provide?

Is there parity with the server-side/android/iOS integration (if applicable)?

Does this require a metadata change? If so, please link the PR from https://github.com/segmentio/destination-scripts.

What are the relevant tickets?

Link to CC ticket

List all the tests accounts you have used to make sure this change works

Helpful Docs

@ccnixon ccnixon requested review from a team September 20, 2018 16:44
Copy link
Contributor

@CarlosMecha CarlosMecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jlee9595
Copy link
Contributor

Could you give a quick brief on why we had to add the eslint stuff and didn't just have to remove a single line that runs the autocorrect cmd?

@ccnixon
Copy link
Contributor Author

ccnixon commented Sep 20, 2018

Well we actually weren't really running a lint process before, we were just formatting. This now adds an actual lint check and will throw errors if your code doesn't adhere to our lint rules.

@jlee9595
Copy link
Contributor

Gotcha, thanks!

@ccnixon ccnixon merged commit 36f524f into master Sep 20, 2018
@ccnixon ccnixon deleted the remove-autoformatter branch September 20, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants