Skip to content

feat: Support retry failure policy for event based functions #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2021

Conversation

flaviomp
Copy link
Contributor

@flaviomp flaviomp commented Mar 10, 2021

Resolves #131

functions:
  pubsub-function:
    handler: processPubSub
    events:
      - event:
          eventType: providers/cloud.pubsub/eventTypes/topic.publish
          resource: projects/${self:provider.project}/topics/my-topic
          failurePolicy:
            retry: {}

@frederikvanhevel
Copy link

Whats the status of this? I need to be able to set this flag. I would also like to specify the max instances like what is documented here: https://cloud.google.com/functions/docs/max-instances

@flaviomp
Copy link
Contributor Author

@pgrzesik, based on the latest releases, I think you are the only maintainer for this project. Would you mind to take a look at this? Thanks.

@pgrzesik
Copy link
Contributor

Thanks for pining me @flaviomp - I'm trying to unblock the PRs and push releases if possible, but honestly I'm no expert on Google Cloud itself. The proposed PR looks good though 👍

@pgrzesik pgrzesik changed the title Support retry failure policy for event based Cloud Functions feat: Support retry failure policy for event based functions Jul 26, 2021
@pgrzesik pgrzesik merged commit 6ab7711 into serverless:master Jul 26, 2021
@oakesja
Copy link

oakesja commented Aug 3, 2021

@pgrzesik anyway we can get a new release for this change?

@pgrzesik
Copy link
Contributor

pgrzesik commented Aug 3, 2021

Hey @oakesja 👋 It was just released with 4.3.0

@engineforce
Copy link

engineforce commented Oct 20, 2021

Sorry, how do I pass backoff properties to the retry object? I cannot find any documentation about what are the properties in this retry object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable --retry flag for background functions
5 participants