This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Make VM metrics host dimension configurable #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dloucasfx
requested review from
a team,
keitwb,
asuresh4 and
rmfitzpatrick
as code owners
dloucasfx
force-pushed
the
OTL-1546
branch
2 times, most recently
from
c2685d1 to
6a2919a
Compare
pmcollins
reviewed
Aug 15, 2022
pmcollins
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Just one tiny nit (feel free to ignore), otherwise LGTM. Thanks for doing this @dloucasfx.
Signed-off-by: Dani Louca <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.