[ansible][windows] Add option to set service CLI args (#6371)

* [ansible][windows] Add support to custom cmd line

* Fix lint

* Remove `when` conditional from the assert

* Remove conditional from custom_vars Windows test

* Playbook option is not available on verify step

* Remove accidental changes on Makefile

Author: pjanotti

deployments/ansible/molecule/custom_vars/windows-converge.yml

@@ -22,6 +22,7 @@
       MY_CUSTOM_VAR1: value1
       MY_CUSTOM_VAR2: value2
       MY_CUSTOM_VAR3: 'value3 with spaces'
+    splunk_otel_collector_command_line_args: "--discovery"
     install_splunk_dotnet_auto_instrumentation: true
     splunk_dotnet_auto_instrumentation_version: 1.8.0
     splunk_dotnet_auto_instrumentation_system_wide: true

deployments/ansible/molecule/custom_vars/windows-verify.yml

@@ -95,3 +95,14 @@
       assert:
         that: (item.key + '=' + (item.value | string)) in collector_env.value
       loop: "{{ collector_reg_values | dict2items }}"
+
+    - name: Get splunk-otel-collector service ImagePath
+      ansible.windows.win_reg_stat:
+        path: HKLM:\SYSTEM\CurrentControlSet\Services\splunk-otel-collector
+        name: ImagePath
+      register: collector_imagepath
+
+    - name: Assert service ImagePath ends with the splunk_otel_collector_command_line_args value used in the playbook
+      assert:
+        that:
+          - collector_imagepath.value.endswith("--discovery")

deployments/ansible/roles/collector/tasks/otel_win_install.yml

@@ -31,6 +31,8 @@
       - "{{ 'SPLUNK_MEMORY_TOTAL_MIB=' + (splunk_memory_total_mib | string)
                if (splunk_memory_total_mib | string) != '' else '' }}"
       - "{{ 'SPLUNK_REALM=' + splunk_realm if splunk_realm != '' else '' }}"
+      - "{{ 'COLLECTOR_SVC_ARGS=' + splunk_otel_collector_command_line_args
+               if splunk_otel_collector_command_line_args != '' else '' }}"
 
 - name: Filter out undefined arguments
   when: splunk_collector_msi_is_configurable is defined
@@ -95,4 +97,4 @@
   ansible.windows.win_template:
     src: "{{splunk_otel_collector_config_source}}"
     dest: "{{splunk_otel_collector_config}}"
-  when: splunk_otel_collector_config_source != ""
+  when: splunk_otel_collector_config_source != ''