[receiver/discovery] Replace log_record field to message
#4916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
discovery-simplify-message-interface
branch
2 times, most recently
from
17f0a65 to
a4fbcde
Compare
`log_record` field isn't relevant anymore since we don't send discovery events as log records. The provided value is set to `discovery.message` entity attribute and sent to the backend on a regular basis. The additional `log_record.attributes` field is not being used. If needed in future, it can be added as another field in the statement section itself.
dmitryax
force-pushed
the
discovery-simplify-message-interface
branch
from
a4fbcde to
d019785
Compare
samiura
approved these changes
Jun 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_recordfield isn't relevant anymore since we don't send discovery events as log records. The provided value is set todiscovery.messageentity attribute and sent to the backend on a regular basis.The additional
log_record.attributesfield is not being used. If needed in the future, it can be added as another field in the statement section itself.