Skip to content

Add entites for Agent - GW setup #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025
Merged

Add entites for Agent - GW setup #6311

merged 3 commits into from
Jun 26, 2025

Conversation

dloucasfx
Copy link
Contributor

Description:

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:

Documentation:

@dloucasfx dloucasfx requested review from a team as code owners June 13, 2025 00:42
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.92%. Comparing base (95a48d6) to head (aa8e3e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6311      +/-   ##
==========================================
- Coverage   44.94%   44.92%   -0.03%     
==========================================
  Files         390      390              
  Lines       27010    27010              
==========================================
- Hits        12139    12133       -6     
- Misses      14004    14009       +5     
- Partials      867      868       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dloucasfx dloucasfx requested a review from a team as a code owner June 13, 2025 03:41
@dloucasfx dloucasfx force-pushed the entitiesGW branch 2 times, most recently from c3e6f71 to 27e55e5 Compare June 16, 2025 15:11
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context for this change, please let me know if I'm misunderstanding anything here.

Have you been able to test the routing connector functionality added here?

@@ -142,6 +142,22 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false
# To send entities (applicable only if discovery mode is enabled)
otlphttp/entities:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only relevant when discovery is enabled, is there some way to tie this to discovery mode? (The pipeline is only enabled when discovery mode is enabled?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on the GW side and discovery might not be enabled there but enabled at the sender

@crobert-1
Copy link
Contributor

I haven't seen that linux-package-test/docker-otelcol-verify failure before:

exec /usr/lib/splunk-otel-collector/agent-bundle/bin/python: no such file or directory

Please check to make sure it's not caused by this PR, we can address later if it's unrelated.

@dloucasfx
Copy link
Contributor Author

I don't have much context for this change, please let me know if I'm misunderstanding anything here.

Have you been able to test the routing connector functionality added here?

yes, this was validated manually

Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dloucasfx dloucasfx merged commit ad663b1 into main Jun 26, 2025
517 of 524 checks passed
@dloucasfx dloucasfx deleted the entitiesGW branch June 26, 2025 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants