-
Notifications
You must be signed in to change notification settings - Fork 167
Add entites for Agent - GW setup #6311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6311 +/- ##
==========================================
- Coverage 44.94% 44.92% -0.03%
==========================================
Files 390 390
Lines 27010 27010
==========================================
- Hits 12139 12133 -6
- Misses 14004 14009 +5
- Partials 867 868 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c3e6f71
to
27e55e5
Compare
Signed-off-by: Dani Louca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context for this change, please let me know if I'm misunderstanding anything here.
Have you been able to test the routing connector functionality added here?
@@ -142,6 +142,22 @@ exporters: | |||
token: "${SPLUNK_ACCESS_TOKEN}" | |||
endpoint: "${SPLUNK_INGEST_URL}/v1/log" | |||
log_data_enabled: false | |||
# To send entities (applicable only if discovery mode is enabled) | |||
otlphttp/entities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only relevant when discovery is enabled, is there some way to tie this to discovery mode? (The pipeline is only enabled when discovery mode is enabled?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on the GW side and discovery might not be enabled there but enabled at the sender
I haven't seen that
Please check to make sure it's not caused by this PR, we can address later if it's unrelated. |
yes, this was validated manually |
Signed-off-by: Dani Louca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: