-
Notifications
You must be signed in to change notification settings - Fork 167
[deployments] Mark Fluentd support as deprecated #6339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
crobert-1
merged 21 commits into
signalfx:main
from
crobert-1:deployments_deprecate_fluentd
Jun 25, 2025
Merged
[deployments] Mark Fluentd support as deprecated #6339
crobert-1
merged 21 commits into
signalfx:main
from
crobert-1:deployments_deprecate_fluentd
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
=======================================
Coverage 44.90% 44.91%
=======================================
Files 390 390
Lines 26995 26995
=======================================
+ Hits 12123 12124 +1
+ Misses 14005 14004 -1
Partials 867 867 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9bcb026
to
a884526
Compare
crobert-1
commented
Jun 23, 2025
dd8d756
to
1341d11
Compare
pjanotti
approved these changes
Jun 24, 2025
dmitryax
approved these changes
Jun 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Marks Fluentd support as deprecated in all mass deployments that support it. Add a central deprecation doc to reference. Whenever a deployment has fluentd enabled also log a warning message that it's deprecated.