Skip to content

[windows installer script] Mark Fluentd support as deprecated #6362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented Jun 24, 2025

Description:
Follow up to #6264, for the Windows installer script this time.

Testing:

> Get-Help .\packaging\installer\install.ps1 -detailed
...
    -with_fluentd <Boolean>
        DEPRECATED: Fluentd support has been deprecated and will be removed in a future release.
        Please refer to documentation for more information: https://github.com/signalfx/splunk-ot
        el-collector/blob/main/docs/deprecations/fluentd-support.md
        (OPTIONAL) Whether to install and configure fluentd to forward log events to the
        collector (default: $false)
> .\packaging\installer\install.ps1 -with_fluentd $True
...
WARNING: [DEPRECATED] Fluentd support has been deprecated and will be removed in a future release.
 Please refer to documentation for more information:
https://github.com/signalfx/splunk-otel-collector/blob/main/docs/deprecations/fluentd-support.md

Copy link
Contributor

github-actions bot commented Jun 24, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (95a48d6) to head (34d6dc8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6362   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files         390      390           
  Lines       27010    27010           
=======================================
  Hits        12139    12139           
  Misses      14004    14004           
  Partials      867      867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 force-pushed the windows_installer_dep_fluentd branch from 8bfc381 to 9215916 Compare June 24, 2025 23:37
@crobert-1 crobert-1 marked this pull request as ready for review June 25, 2025 15:10
@crobert-1 crobert-1 requested review from a team as code owners June 25, 2025 15:10
@crobert-1 crobert-1 force-pushed the windows_installer_dep_fluentd branch from 9215916 to 34d6dc8 Compare June 25, 2025 15:24
@crobert-1 crobert-1 merged commit 3d42382 into signalfx:main Jun 25, 2025
42 checks passed
@crobert-1 crobert-1 deleted the windows_installer_dep_fluentd branch June 25, 2025 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants