ErrNoSignaturesFound should be used when there is no signature attached to an image.

[zhaoyonghe]

Summary

This PR closes #3525.

Release Note

NONE

Documentation

No documentation change.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ef6022) 40.10% compared to head (a6fa8dd) 40.46%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3526      +/-   ##
==========================================
+ Coverage   40.10%   40.46%   +0.35%     
==========================================
  Files         155      155              
  Lines       10044    10044              
==========================================
+ Hits         4028     4064      +36     
+ Misses       5530     5491      -39     
- Partials      486      489       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[haydentherapper]

Any test updates?

[zhaoyonghe]

Any test updates?

The current tests only check whether an error occurs or not. I do not see them checking the return error type and message. Therefore, this change should not break any current tests.

[haydentherapper]

What about adding a test that covers this code path?

[zhaoyonghe]

What about adding a test that covers this code path?

Yes. I can do that. Do you mean checking the exit code in the test scripts?

Now we indeed return NoMatchingSignature (12) in ImageWithoutSignature (10) cases.

[haydentherapper]

It can be simpler - Add a unit test that calls verifySignatures with signature struct without signatures and verifies the returned error.

[haydentherapper]

Thanks!