[MNT] Clearly define the MLP as a class/nn.model

[jobs-git]

In the nhits paper: https://arxiv.org/abs/2201.12886, shows that the MLP as component of the Block, the current code does integrates this already as series of appended layers.

This pull request instead clearly defines the MLP as a class/nn.model.

Description

This PR ...

Checklist

• Linked issues (if existing)
• Amended changelog for large changes (and added myself there as contributor)
• Added/modified tests
• Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
  To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

[fkiraly]

Thanks! Though, there is an error in the code if you execute it, constructor call is misnamed.

[fkiraly]

seems like there are still some failures - are these caused by your changes?

[codecov]

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4a34931). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pytorch_forecasting/models/nhits/sub_modules.py	90.47%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1864   +/-   ##
=======================================
  Coverage        ?   85.74%           
=======================================
  Files           ?       68           
  Lines           ?     6594           
  Branches        ?        0           
=======================================
  Hits            ?     5654           
  Misses          ?      940           
  Partials        ?        0           

Flag	Coverage Δ
cpu	85.74% <90.47%> (?)
pytest	85.74% <90.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fkiraly]

Looks good now!