Implement the Drain::flush method #39
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sends a message to the logging thread, then blocks until the logger acknowledges it. Contrast this to the busy-loop approach in slog-rs#36 Pinned to the branch used in PR #349, so cannot be released until that PR is accepted. Fixes issue slog-rs#35
Techcable
changed the title
Techcable
added a commit
to Techcable/slog-json
that referenced
this pull request
Aug 9, 2025
Pinned to the branch used in slog-rs/slog#349, so that must be accepted first. The 'pretty' example is pinned to use the branch in slog-rs/async#39, so that must also be accepted first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends a message to the logging thread, then blocks until the logger acknowledges it.
Contrast this to the busy-loop approach in #36
Pinned to the branch used in PR slog-rs/slog#349, so cannot be released until that PR is accepted.
Fixes issue #35