workspace/symbol result location should correspond to identifier

[beyang]

• Go to https://sourcegraph.com/github.com/palantir/tslint
• Issue a workspace/symbol query for "#getFileNames"
• Notice that you jump to the correct file, but the offset is incorrect. It should point to the start of the identifier getFileNames, but instead points to the start of public static getFileNames.

This fix is necessary for cross-repository hovers (see https://github.com/sourcegraph/sourcegraph/pull/4873)

[felixfbecker]

I doubt this in our control - isn't the location returned by the TypeScript LanguageService?
Why is this needed for cross-repository hovers?

[beyang]

Let's put this on the backburner for now. I want to wait to what changes happen on the UI side in the next couple of weeks and whether this is still necessary.

[lindaxie-zz]

Unable to repro. See #189.

[nicksnyder]

If you set a correct offset, then the UI will highlight the token when you land on the file. Go language server sets the offset correctly so if this is possible then it is worth doing.

[felixfbecker]

@nicksnyder You mean if the range spans less than a full line? TypeScript gives us this range as the range of the symbol - a fix would only be possible upstream or by implementing a hack that again iterates the AST and finds the first identifier node in the range.

[nicksnyder]

If we are getting this range from TypeScript itself then I would try opening the issue with them to see what they think. Is the range always a full line right now? imo, the token is what I would want a range for. Not sure what the datastructure TypeScript exposes, but maybe they could expose both ranges?