Spring data redis is not working for custom converter [DATAREDIS-911]

[spring-projects-issues]

Shivam Rohilla opened DATAREDIS-911 and commented

Spring data redis is not working for custom converter.

in class org.springframework.data.redis.core.convert.MappingRedisConverter

in writeInternal method in below code snippet :-

!StringUtils.hasText(path) && customConversions.getCustomWriteTarget(value.getClass()).equals(byte[].class))

 

it's returning the Optional object and when getClass() is called it returns Optional, so it's comparing Optional class with bytes class.

This is crashing and converters are not working

---

Affects: 2.1.3 (Lovelace SR3)

1 votes, 4 watchers

[spring-projects-issues]

Mark Paluch commented

What are you trying to achieve. Do you have some sample code to illustrate your use case?

[spring-projects-issues]

Shivam Rohilla commented

Mark Paluch,

   I am trying to add the data in cache on service start.

Class object that is being stored in cache has custom converter but it's crashing.

Sample code for configuration :-

 

Writing converter – 

@WritingConverter

public class PlayerDataWriteConverter implements Converter<PlayerData, byte[]> {
private final Jackson2JsonRedisSerializer<PlayerData> serializer;
public PlayerDataWriteConverter() { serializer = new Jackson2JsonRedisSerializer<PlayerData>(PlayerData.class); serializer.setObjectMapper(new ObjectMapper()); }
@Override public byte[] convert(PlayerData value) { return serializer.serialize(value); }
}

 

Reading Converter :-

 

@ReadingConverter

public class PlayerDataReadConverter implements Converter<byte[], PlayerData> {
private final Jackson2JsonRedisSerializer<PlayerData> serializer;
public PlayerDataReadConverter() { serializer = new Jackson2JsonRedisSerializer<PlayerData>(PlayerData.class); serializer.setObjectMapper(new ObjectMapper()); }
@Override public PlayerData convert(byte[] value) { // TODO Auto-generated method stub return serializer.deserialize(value); }
}

 

DAO for cache :-

public interface PlayerCacheRepository extends CrudRepository<PlayerData, Long>,  QueryByExampleExecutor<PlayerData> {
Page<PlayerData> findByPlayerId(Long id, Pageable page);

Optional<PlayerData> findByIdAndMatchesId(Long id, Long matchId);

List<PlayerData> findByPlayerId(Long id);

}

 

Redis config :-

@Bean

public RedisConnectionFactory redisConnectionFactory() {

LettuceConnectionFactory connectionFactory = new LettuceConnectionFactory(); return connectionFactory;

}
@Bean public RedisTemplate<String, PlayerData> redisTemplate() {

RedisTemplate<String, PlayerData> redisTemplate = new RedisTemplate<>();

redisTemplate.setConnectionFactory(redisConnectionFactory()); return redisTemplate;

}

@Bean
public RedisCustomConversions redisCustomConversions() {
return new RedisCustomConversions(Arrays.asList(new PlayerDataReadConverter(), new PlayerDataWriteConverter()));
}

 

[spring-projects-issues]

Shivam Rohilla commented

and while calling save method of DAO it's calling the shared description code and on mismatch it's crashing

[spring-projects-issues]

Mark Paluch commented

Thanks for the code. Custom converters are not intended for top-level type usage. Objects accessed through a Redis Repository are mapped to Redis Hashes which means that objects are represented as set of key-value tuples. The converter above expresses the intent to store an object in a single field and this does not meet the storage strategy of Redis Repositories.

Converters come into play when serializing individual object properties to store a single property as e.g. JSON

[spring-projects-issues]

ChetanSankhala commented

Mark Paluch,  as you said "Converters come into play when serializing individual object properties to store a single property as e.g. JSON", in this case also, below line will be executed:

!StringUtils.hasText(path) && customConversions.getCustomWriteTarget(value.getClass()).equals(byte[].class))
Don't you think it will create issue that time?

[spring-projects-issues]

Rahul Sharma commented

Mark Paluch this is a blocker for me too. Even if custom converters are not intended for top level usage, an Optional will never be an equal to byte[].class - regardless of the usage