Add approximate trim support for XTRIM [DATAREDIS-1085]

[spring-projects-issues]

Sergey Karimov opened DATAREDIS-1085 and commented

Redis from some version, don't know which exactly, supports following syntax:

xadd somekey maxlen ~ 1 * key1 value1

key feature here is "maxlen ~ 1" (may be any number).

same for:

xtrim somekey ~ 1

There is no way to specify "maxlen ~ 1" for xadd via ReactiveStreamCommands or RedisStreamCommands.

There is no way to specify "xtrim somekey ~ 1" via ReactiveStreamCommands or RedisStreamCommands, only "xtrim somekey 1", which is huge preformance impact compared to "xtrim somekey ~ 1"

---

Affects: 2.2.3 (Moore SR3)

Issue Links:

• DATAREDIS-1122 Add support for MAXLEN attribute of XADD

Referenced from: pull request https://github.com/spring-projects/spring-data-redis/pull

2 votes, 5 watchers

[spring-projects-issues]

YiuTerran commented

why this bug still not fixed?

[spring-projects-issues]

Mark Paluch commented

Thanks for reaching out. Feel free to submit a pull request yiuterran to help in getting this issue done

[spring-projects-issues]

Mark Paluch commented

Support for XADD MAXLEN was introduced with DATAREDIS-1122

[peterspikings]

What about XTRIM ~ ? There's a method in Lettuce which takes a boolean for approximate trimming, all it needs is a passthrough, should I do a PR? :)

[mp911de]

Care to elaborate what's missing? 99cf4a2 introduced xTrim(byte[] key, long count, boolean approximateTrimming) on the connection API and trim(K key, long count, boolean approximateTrimming) on the Template API.

[peterspikings]

Sorry, my bad! It was exactly those I was after and didn't realise I was looking at an old version which didn't have them (2.3.7) even though the underlying Lettuce implementation did. From the comments it looks like you just changed the XADD :) I'll get my coat....